[SOLVED] - BUG - Messages with talk are not shared with user in talk if public talk are disabled

If You disable the public talk for some or all users when you send a talk to user inside a message (email) the recipients can't open the message (autorization denied).

SOLUTION:

In modules/Messages/Messages.php around line 1657 find something like:

if ($user->column_fields == '1') {
$query .= "(visibility_comm = ? AND {$this->entity_table}.smownerid <> ?) OR";
}
$query .= "(visibility_comm = ? AND COALESCE({$table_prefix}_modcomments_users.user,0) = ?))";
$params = array('Messages','All',$user->id,'Users',$user->id);

replace with:

$params[]=array('Messages');
if ($user->column_fields == '1') {
$query .= "(visibility_comm = ? AND {$this->entity_table}.smownerid <> ?) OR";
$params[]=array('All',$user->id);
}
$query .= "(visibility_comm = ? AND COALESCE({$table_prefix}_modcomments_users.user,0) = ?))";
$params[] = array('Users',$user->id);

There are some errors in the solution. Here the correct solution:

$params[] = 'Messages';
if ($user->column_fields == '1') {
$query .= "(visibility_comm = ? AND {$this->entity_table}.smownerid <> ?) OR";
array_push($params, 'All', $user->id);
}
$query .= "(visibility_comm = ? AND COALESCE({$table_prefix}_modcomments_users.user,0) = ?))";
array_push($params, 'Users', $user->id);

Thank you for the answer.

With php 5.3 on ubuntu 12.04 64 bit I don't get any error, not even a warning by php debugger. I think could be a different syntax for the same thing?

cp